Autosign #52
Open
Autosign #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running both on a (puppet server) node, to avoid the cert initialization problem.
based autosigning using a combination of the following new
parameters:
- autosign: Path to the autosign file to use
Default: /etc/puppetlabs/puppet/autosign.conf
- autosign_runnable: Boolean of whether autosign file is executable
Setting to true will enable policy-based autosigning, and require
autosign_script to be supplied
Default: false
- autosign_list: Array of domains to match for basic autosigning.
Requires autosign_runnable to be false.
Default: []
- autosign_script: String content of script to use for policy-
based autosigning. Requires autosign_runnable to be true.
Default: ""
| $autosign = '/etc/puppetlabs/puppet/autosign.conf' | ||
| $autosign_runnable = false | ||
| $autosign_list = [] | ||
| $autosign_script = '' |
There was a problem hiding this comment.
This is causing the tests to fail. Puppet 4 has an actual undef so using that value is the way to go.
|
Thanks! Could you take a look at the empty string thing so tests are happy? After that I'll merge it in! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for setting up basic and policy-based autosign for the Puppet server.